[Spice-devel] [PATCH spice-gtk 4/4] Add default .gitpublish profile

[Victor Toso]

Hi,

On Tue, Mar 28, 2017 at 11:10:54AM -0400, Marc-André Lureau wrote:
>
> ----- Original Message -----
> > On Tue, 2017-03-28 at 16:37 +0200, Victor Toso wrote:
> > > Hi,
> > > 
> > > On Tue, Mar 28, 2017 at 03:51:34PM +0200, marcandre.lureau at redhat.co
> > > m wrote:
> > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > 
> > > > Can be quite handy for git-publish users like me.
> > > > (https://github.com/stefanha/git-publish)
> > > > 
> > > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > ---
> > > >  .gitpublish | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >  create mode 100644 .gitpublish
> > > > 
> > > > diff --git a/.gitpublish b/.gitpublish
> > > > new file mode 100644
> > > > index 0000000..b51a404
> > > > --- /dev/null
> > > > +++ b/.gitpublish
> > > > @@ -0,0 +1,4 @@
> > > > +[gitpublishprofile "default"]
> > > > +to = spice-devel at lists.freedesktop.org
> > > > +prefix = PATCH spice-gtk
> > > > +signoff = true
> > > 
> > > I didn't test it but should those go into .git/config instead or it
> > > would simply not work on git-publish?
> > 
> > I have this stuff in git config
> 
> git-publish uses format-patch, so format.subjectPrefix git config
> works, for instance.  It also use git send-email. But To: is not shown
> in the summary. I am not sure if you should set both format.to and
> sendemail.to in gitconfig.
>
> So it can work ok, but users have to configure git themselves. Here
> gitpublish would work immediately.

Looks fine to me
Acked-by: Victor Toso <victortoso at redhat.com>

> 
> > 
> > > 
> > > > --
> > > > 2.12.0.191.gc5d8de91d
> > > > 
> > > > _______________________________________________
> > > > Spice-devel mailing list
> > > > Spice-devel at lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> > > 
> > > _______________________________________________
> > > Spice-devel mailing list
> > > Spice-devel at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> > 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170328/82d4e0b3/attachment.sig>