[Spice-devel] [PATCH spice-server] sound: Store only playback channels in global list

[Christophe Fergeau]

On Wed, May 03, 2017 at 06:06:21AM -0400, Frediano Ziglio wrote:
> > 
> > On Wed, May 03, 2017 at 10:47:48AM +0100, Frediano Ziglio wrote:
> > > The list is used only to iterate playback channels
> > 
> > This patch seems only partial?
> > 
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  server/sound.c | 19 +++++++------------
> > >  1 file changed, 7 insertions(+), 12 deletions(-)
> > > 
> > > diff --git a/server/sound.c b/server/sound.c
> > > index be7e607..64cd6d4 100644
> > > --- a/server/sound.c
> > > +++ b/server/sound.c
> > > @@ -234,7 +234,7 @@ G_DEFINE_TYPE(RecordChannelClient,
> > > record_channel_client, TYPE_SND_CHANNEL_CLIEN
> > >  
> > >  
> > >  /* A list of all Spice{Playback,Record}State objects */
> 
> OT: this comment needs update too.. and perhaps not so OT.
> 
> > > -static GList *snd_channels;
> > > +static GList *snd_playback_channels;
> > >  
> > >  static void snd_send(SndChannelClient * client);
> > >  
> > > @@ -980,12 +980,10 @@ void snd_set_playback_latency(RedClient *client,
> > > uint32_t latency)
> > >  {
> > >      GList *l;
> > >  
> > > -    for (l = snd_channels; l != NULL; l = l->next) {
> > > +    for (l = snd_playback_channels; l != NULL; l = l->next) {
> > >          SndChannel *now = l->data;
> > 
> > The shortlog says l->data should be a SndChannelClient now?
> > 
> 
> ?? why you expect a client now? Neither in the subject not in commit
> log I said client, is and was a channel, not a channel client.

Oh whatever, I read "channel client" rather than "playback channel" in
the log.

/me goes to read the patch again.

Christopeh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170503/49986a83/attachment.sig>