[Spice-devel] [PATCH spice-gtk v2 0/5] Always use Playbin to create the pipeline

Victor Toso victortoso at redhat.com
Thu May 11 16:37:46 UTC 2017


From: Victor Toso <me at victortoso.com>

-- v1-> v2:

Adressing Frediano comments in v1

* Rebased
* Removed caps="" for older version of GStreamer. No clear info on the
  issue that one had at that time. Still, video/x-h264 is the stream
  format that we receive and an error because of that should really be a
  bug in GStreamer.
* Moved v1 02/04 to be v2 01/04 in order to fix more easily the
  "cap=%s" problem in v1 01/04
* Free GstSample even while using playbin
* gst_element_ref() GstAppSrc and GstAppSink

-- v1:

Hi,

First time using git-publish [0], sorry if anything goes wrong :)

[0] https://github.com/stefanha/git-publish

The main goal for this series is to have streaming working with hardware
accelerated video decoding whenever is possible.

The best way to achieve that is to let GStreamer do most of the work. Using
Playbin [1] we can create the whole pipeline. We only need to work with
GstAppSrc and GstAppSink to set the encoded data and gather the decoded data.

[1] https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-plugins/html/gst-plugins-base-plugins-playbin.html

Trying my best to not break streaming with older versions of GStreamer. Based on
a comment from ceyusa [2], since version 1.9.0 GStreamer is able to use Vaapi
elements automaticaly and for that reason I'm wrapping those changes with
GST_CHECK_VERSION(1,9,0).

[2] https://lists.freedesktop.org/archives/spice-devel/2016-October/032825.html

Cheers,
        toso

Victor Toso (5):
  display-gst: include capabilities for h264
  display-gst: move "caps=" from struct to pipeline
  display-gst: check GstRegistry for decoding elements
  display-gst: remove SPICE_GSTVIDEO_AUTO check
  display-gst: Use Playbin for GStreamer 1.9.0 onwards

 src/channel-display-gst.c | 184 +++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 156 insertions(+), 28 deletions(-)

-- 
2.12.2



More information about the Spice-devel mailing list