[Spice-devel] [spice-gtk] glz: Remove unused DECODE_TO_SAME array

Victor Toso victortoso at redhat.com
Tue May 16 15:21:56 UTC 2017


Hi,

On Tue, May 16, 2017 at 05:12:42PM +0200, Christophe Fergeau wrote:
> This also removes the generation of unneeded _decode methods once this
> array is removed (this causes some warnings otherwise).
>
> DECODE_TO_SAME was used in the old client, but was never used when this
> code was moved over to spice-gtk.

Looks fine
Acked-by: Victor Toso <victortoso at redhat.com>

>
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  src/decode-glz.c | 21 ---------------------
>  1 file changed, 21 deletions(-)
> 
> diff --git a/src/decode-glz.c b/src/decode-glz.c
> index d5b72ab5..27765393 100644
> --- a/src/decode-glz.c
> +++ b/src/decode-glz.c
> @@ -238,9 +238,6 @@ typedef uint16_t rgb16_pixel_t;
>  #undef ATTR_PACKED
>  
>  #define LZ_PLT
> -#include "decode-glz-tmpl.c"
> -
> -#define LZ_PLT
>  #define PLT8
>  #define TO_RGB32
>  #include "decode-glz-tmpl.c"
> @@ -267,14 +264,9 @@ typedef uint16_t rgb16_pixel_t;
>  
>  
>  #define LZ_RGB16
> -#include "decode-glz-tmpl.c"
> -#define LZ_RGB16
>  #define TO_RGB32
>  #include "decode-glz-tmpl.c"
>  
> -#define LZ_RGB24
> -#include "decode-glz-tmpl.c"
> -
>  #define LZ_RGB32
>  #include "decode-glz-tmpl.c"
>  
> @@ -302,19 +294,6 @@ const decode_function DECODE_TO_RGB32[] = {
>      glz_rgb32_decode
>  };
>  
> -const decode_function DECODE_TO_SAME[] = {
> -    NULL,
> -    glz_plt_decode,
> -    glz_plt_decode,
> -    glz_plt_decode,
> -    glz_plt_decode,
> -    glz_plt_decode,
> -    glz_rgb16_decode,
> -    glz_rgb24_decode,
> -    glz_rgb32_decode,
> -    glz_rgb32_decode
> -};
> -
>  static uint32_t decode_32(GlibGlzDecoder *d)
>  {
>      uint32_t word = 0;
> -- 
> 2.12.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170516/839f272e/attachment.sig>


More information about the Spice-devel mailing list