[Spice-devel] [PATCH 4/4] vdagent: Use glib's commandline parser
Victor Toso
victortoso at redhat.com
Tue May 16 16:09:10 UTC 2017
Hi,
On Tue, May 16, 2017 at 11:45:10AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso <me at victortoso.com>
> >
> > As we already depend on glib, let's remove code that glib can take
> > care. In this case, we don't need to handle commandline parsing
> > ourselves.
> >
> > In regard the global variables:
> >
> > * static const char * -> static char * [only paths]
> > path variables: portdev, fx_dir, vdagentd_socket
> >
> > * static int -> static gboolean
> > flags: debug, do_daemonize, x11_sync, fx_open_dir
> >
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> > src/vdagent/vdagent.c | 107
> > +++++++++++++++++++++++---------------------------
> > 1 file changed, 49 insertions(+), 58 deletions(-)
> >
> > diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c
> > index 4f8079f..2c4ec3f 100644
> > --- a/src/vdagent/vdagent.c
> > +++ b/src/vdagent/vdagent.c
> > @@ -45,17 +45,45 @@
> > #include "x11.h"
> > #include "file-xfers.h"
> >
> > -static const char *portdev = DEFAULT_VIRTIO_PORT_PATH;
> > -static const char *vdagentd_socket = VDAGENTD_SOCKET;
> > -static int debug = 0;
> > -static const char *fx_dir = NULL;
> > -static int fx_open_dir = -1;
> > static struct vdagent_x11 *x11 = NULL;
> > static struct vdagent_file_xfers *vdagent_file_xfers = NULL;
> > static struct udscs_connection *client = NULL;
> > static int quit = 0;
> > static int version_mismatch = 0;
> >
> > +/* Command line options */
> > +static gboolean debug = FALSE;
> > +static gboolean x11_sync = FALSE;
> > +static gboolean fx_open_dir = FALSE;
> > +static gboolean do_daemonize = TRUE;
> > +static char *fx_dir;
> > +static char *portdev = DEFAULT_VIRTIO_PORT_PATH;
> > +static char *vdagentd_socket = VDAGENTD_SOCKET;
>
> Why don't you get a warning here? You are assigning a constant string
> to a not const one. What's the problem of the old declaration?
I'll make it const again. Not sure what there is no warning (tried with
-Wall here)
> GOptionEntry accepts any not const pointer and a const char ** is a not
> const pointer.
Yes, my mistake
>
> > +
> > +static GOptionEntry entries[] ={
> > + { "debug", 'd', 0,
> > + G_OPTION_ARG_NONE, &debug,
> > + "Enable debug", NULL },
> > + { "foreground", 'x', G_OPTION_FLAG_REVERSE,
> > + G_OPTION_ARG_NONE, &do_daemonize,
> > + "Do not daemonize the agent", NULL },
> > + { "x11-abort-on-error", 'y', 0,
> > + G_OPTION_ARG_NONE, &x11_sync,
> > + "Aborts on errors from X11", NULL },
> > + { "file-xfer-open-dir", 'o', 0,
> > + G_OPTION_ARG_NONE, &fx_open_dir,
> > + "Open directory after completing file transfer", NULL },
> > + { "virtio-serial-port-path", 's', 0,
> > + G_OPTION_ARG_STRING, &portdev,
> > + "Set virtio-serial path (" DEFAULT_VIRTIO_PORT_PATH ")", NULL },
> > + { "file-xfer-save-dir", 'f', 0,
> > + G_OPTION_ARG_STRING, &fx_dir,
> > + "Set directory to file transfers files", NULL},
> > + { "vdagentd-socket", 'S', 0, G_OPTION_ARG_STRING,
> > + &vdagentd_socket,
> > + "Set spice-vdagentd socket (" VDAGENTD_SOCKET ")", NULL },
> > +};
> > +
> > /**
> > * xfer_get_download_directory
> > *
> > @@ -217,22 +245,6 @@ static int client_setup(int reconnect)
> > return client == NULL;
> > }
> >
> > -static void usage(FILE *fp)
> > -{
> > - fprintf(fp,
> > - "Usage: spice-vdagent [OPTIONS]\n\n"
> > - "Spice guest agent X11 session agent, version %s.\n\n"
> > - "Options:\n"
> > - " -h print this text\n"
> > - " -d log debug messages\n"
> > - " -s <port> set virtio serial port\n"
> > - " -S <filename> set udcs socket\n"
> > - " -x don't daemonize\n"
> > - " -f <dir|xdg-desktop|xdg-download> file xfer save dir\n"
> > - " -o <0|1> open dir on file xfer
> > completion\n",
> > - VERSION);
> > -}
> > -
> > static void quit_handler(int sig)
> > {
> > quit = 1;
> > @@ -296,45 +308,24 @@ static int file_test(const char *path)
> > int main(int argc, char *argv[])
> > {
> > fd_set readfds, writefds;
> > - int c, n, nfds, x11_fd;
> > - int do_daemonize = 1;
> > + int n, nfds, x11_fd;
> > int parent_socket = 0;
> > - int x11_sync = 0;
> > struct sigaction act;
> > -
> > - for (;;) {
> > - if (-1 == (c = getopt(argc, argv, "-dxhys:f:o:S:")))
> > - break;
> > - switch (c) {
> > - case 'd':
> > - debug++;
> > - break;
> > - case 's':
> > - portdev = optarg;
> > - break;
> > - case 'x':
> > - do_daemonize = 0;
> > - break;
> > - case 'y':
> > - x11_sync = 1;
> > - break;
> > - case 'h':
> > - usage(stdout);
> > - return 0;
> > - case 'f':
> > - fx_dir = optarg;
> > - break;
> > - case 'o':
> > - fx_open_dir = atoi(optarg);
> > - break;
> > - case 'S':
> > - vdagentd_socket = optarg;
> > - break;
> > - default:
> > - fputs("\n", stderr);
> > - usage(stderr);
> > - return 1;
> > - }
> > + GOptionContext *context;
> > + GError *error = NULL;
> > +
> > + context = g_option_context_new(NULL);
> > + g_option_context_add_main_entries(context, entries, NULL);
> > + g_option_context_set_summary(context,
> > + "\tSpice session guest agent: X11\n"
> > + "\tVersion: " VERSION);
> > + g_option_context_parse(context, &argc, &argv, &error);
> > + g_option_context_free(context);
> > +
> > + if (error) {
> > + g_printerr("Invalid arguments, %s\n", error->message);
> > + g_clear_error(&error);
> > + return -1;
> > }
> >
> > memset(&act, 0, sizeof(act));
>
> Frediano
Thanks for the review,
toso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170516/d9bc6fe1/attachment-0001.sig>
More information about the Spice-devel
mailing list