[Spice-devel] [PATCH spice-gtk v3 4/5] Add check for macOS, disable ucontext on macOS (deprecated)

Pavel Grunt pgrunt at redhat.com
Wed May 17 07:42:03 UTC 2017


On Wed, 2017-05-17 at 07:08 +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  configure.ac | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 74b5811..ecab365 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -62,6 +62,18 @@ esac
>  AC_MSG_RESULT([$os_win32])
>  AM_CONDITIONAL([OS_WIN32],[test "$os_win32" = "yes"])
>  
> +AC_MSG_CHECKING([for native macOS])
> +case "$host_os" in
> +     *darwin*)
> +        os_mac=yes
> +        ;;
> +     *)
> +        os_mac=no
> +        ;;
> +esac
> +AC_MSG_RESULT([$os_mac])
> +AM_CONDITIONAL([OS_MAC],[test "$os_mac" = "yes"])
> +
Although I see its benefits I would merge it with the previous switch

>  AC_CHECK_HEADERS([sys/socket.h netinet/in.h arpa/inet.h])
>  AC_CHECK_HEADERS([termios.h])
>  AC_CHECK_HEADERS([epoxy/egl.h],
> @@ -468,6 +480,8 @@ esac
>  if test "$with_coroutine" = "auto"; then
>    if test "$os_win32" = "yes"; then
>      with_coroutine=winfiber
> +  elif test "$os_mac" = "yes"; then
> +    with_coroutine=gthread
>    else
>      with_coroutine=ucontext
>    fi


More information about the Spice-devel mailing list