[Spice-devel] [PATCH spice-gtk v4 0/4] Repair macOS builds for spice-gtk

[Christophe de Dinechin]

From: Christophe de Dinechin <dinechin at redhat.com>

This patch set contains various fixes that repair macOS builds for
spice-gtk (and presumably clang builds as a side effect), notably:

- Fixes for clang-specific warnings, notably on alignment
- Addition of macOS detection in configure script
- A couple minor portablity fixes

This requires an update to spice-common, see
https://lists.freedesktop.org/archives/spice-devel/2017-May/037505.html.
The reference to submodule  in this patch serie is updated with a
reference that can be fetched from https://github.com/c3d/spice-common.git.

Version 2 takes into account comments by Frediano Ziglio and Pavel Grunt,
specifically:

- Clarify purpose and behavior of macros in patch commit message
- Change one case to 'unaligned'
- Improve way to avoid 'unused variable' warning

Acked by: Christophe Fergeau <cfergeau at redhat.com>

Version 3 takes into account comments made by Christophe Fergeau in
his ack message, specifically:

- Improve the log message description of SPICE_(UN)ALIGNED_CAST.
  Hopefully the new one is better.

- Make spaces after commas consistent

In addition, v3 re-enables ucontext on macOS, following comments
that this is the right thing to do for performance. This required the
elimination of one more alignment warning.

Version 4 takes into account comments made by Pavel and Frediano,
specifically:

- Reorder the previous iteration to group things more logically
- Add a TODO comment for macOS in set_mouse_accel

Christophe de Dinechin (4):
  Add check for macOS
  Avoid clang warnings on casts with stricter alignment requirements
  Avoid warning about snprintf on non-Linux platforms
  Remove warning about unused variable when building on macOS

 configure.ac                | 15 +++++++++++++++
 spice-common                |  2 +-
 src/channel-cursor.c        |  6 +++---
 src/channel-display-mjpeg.c |  2 +-
 src/continuation.h          |  6 ++++--
 src/decode-glz-tmpl.c       |  2 +-
 src/spice-channel.c         | 14 +++++++++-----
 src/spice-widget.c          |  7 ++++---
 src/usbutil.c               |  2 +-
 9 files changed, 39 insertions(+), 17 deletions(-)

-- 
2.11.0 (Apple Git-81)