[Spice-devel] [PATCH spice-gtk v3 1/5] Avoid clang warnings on casts with stricter alignment requirements

[Christophe Fergeau]

On Wed, May 17, 2017 at 03:44:48AM -0400, Frediano Ziglio wrote:
> If these 2 hits you are going to have a message for every single pixel
> in the image, potentially millions.
> I'm still convinced, like in this case, that if we are sure that data
> should be aligned no check and warning should be done.
> I'm really sure no architecture on hearth can do check and print in
> a single machine instruction. Actually I don't know any architecture
> where a single check like this can be done in a single instruction.

I was keeping this comment for the review of the spice-common patches
introducing the macros, but I indeed wanted to ask about the performance
impact of the macros, and whether we really need to always do the
checks, or if we should only do these when debug mode is enabled at
build time.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170517/eb30c33c/attachment-0001.sig>