[Spice-devel] [PATCH v2 0/2] macOS enablement patches
Christophe de Dinechin
christophe at dinechin.org
Wed May 17 15:30:42 UTC 2017
From: Christophe de Dinechin <dinechin at redhat.com>
This patch set eliminates warnings detected by clang with respect
to type alignments. Vittorio Toso had submitted something
similar. In this version, I took into account comments by
Christophe Fergeau regarding how to know which casts were
aligned and which ones were not aligned. I added some
instrumentation to detect the two cases.
v2 changes:
- Fix alignment used for checking (alignment of pointed type, not pointer)
- Disable checking entirely if NDEBUG is defined.
- Add G_UNLIKELY to indicate that the branch is not likely to be taken
I saw no obvious equivalent of NDEBUG in Spice code, so I used NDEBUG,
which is the macro used to disable assert() defined in <assert.h>.
Christophe de Dinechin (2):
Style adjustment
Avoid clang warnings on casts with stricter alignment requirements
common/canvas_base.c | 14 ++++---
common/mem.c | 24 ++++++++++++
common/mem.h | 39 ++++++++++++++++++-
common/sw_canvas.c | 104 +++++++++++++++++++++++++--------------------------
4 files changed, 120 insertions(+), 61 deletions(-)
--
2.11.0 (Apple Git-81)
More information about the Spice-devel
mailing list