[Spice-devel] [PATCH spice-server] reds: Remove only assigned 'mcc' field

[Victor Toso]

Hi,

On Fri, May 12, 2017 at 03:14:10PM +0100, Frediano Ziglio wrote:
> This field was never actually used, only changed.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Looks fine
Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  server/reds-private.h | 1 -
>  server/reds.c         | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/server/reds-private.h b/server/reds-private.h
> index b8119ca..915bcf6 100644
> --- a/server/reds-private.h
> +++ b/server/reds-private.h
> @@ -62,7 +62,6 @@ typedef struct RedsMigTargetClient {
>  /* Intermediate state for on going monitors config message from a single
>   * client, being passed to the guest */
>  typedef struct RedsClientMonitorsConfig {
> -    MainChannelClient *mcc;
>      uint8_t *buffer;
>      int buffer_size;
>      int buffer_pos;
> diff --git a/server/reds.c b/server/reds.c
> index 2a8f905..3e30c38 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -1083,7 +1083,6 @@ static void reds_client_monitors_config_cleanup(RedsState *reds)
>      cmc->buffer_size = cmc->buffer_pos = 0;
>      free(cmc->buffer);
>      cmc->buffer = NULL;
> -    cmc->mcc = NULL;
>  }
>  
>  static void reds_on_main_agent_monitors_config(RedsState *reds,
> @@ -1096,7 +1095,6 @@ static void reds_on_main_agent_monitors_config(RedsState *reds,
>      cmc->buffer_size += size;
>      cmc->buffer = realloc(cmc->buffer, cmc->buffer_size);
>      spice_assert(cmc->buffer);
> -    cmc->mcc = mcc;
>      memcpy(cmc->buffer + cmc->buffer_pos, message, size);
>      cmc->buffer_pos += size;
>      msg_header = (VDAgentMessage *)cmc->buffer;
> -- 
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170518/5a4ae35b/attachment.sig>