[Spice-devel] [PATCH spice-gtk] main: Handle file-xfer detailed errors

[Christophe Fergeau]

On Sun, May 28, 2017 at 11:36:34PM +0200, Jakub Janků wrote:
> Log appropriate error messages when we receive
> VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED or
> VD_AGENT_FILE_XFER_STATUS_NO_AGENT.
> ---
>  src/channel-main.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/channel-main.c b/src/channel-main.c
> index af1350c..2a53a3f 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -1882,6 +1882,16 @@ static void main_agent_handle_xfer_status(SpiceMainChannel *channel,
>          g_free(file_size_str);
>          break;
>      }
> +    case VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED:
> +        error = g_error_new_literal(SPICE_CLIENT_ERROR, SPICE_CLIENT_ERROR_FAILED,
> +                                    _("User's session is locked and cannot transfer files, "
> +                                      "unlock and try again."));

unlock it and try again

> +        break;
> +    case VD_AGENT_FILE_XFER_STATUS_NO_AGENT:
> +        error = g_error_new_literal(SPICE_CLIENT_ERROR, SPICE_CLIENT_ERROR_FAILED,
> +                                    _("Could not find an agent connection belonging to the "
> +                                      "active session, file-xfer cancelled."));

Is this meant to be shown to the user? If yes, I don't think this is
a very clear message for someone not really familiar with how file
transfer works.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170529/10bf0274/attachment.sig>