[Spice-devel] [PATCH spice-protocol] agent: Add new file-xfer statuses

Pavel Grunt pgrunt at redhat.com
Mon May 29 12:28:04 UTC 2017


Hello Jakub,

On Sun, 2017-05-28 at 22:59 +0200, Jakub Janků wrote:
> Introduce new error statuses to report more info to clients:
> VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED,
> VD_AGENT_FILE_XFER_STATUS_NO_AGENT
When does it happen? if the agent disconnects during a file transfer?
Maybe _STATUS_AGENT_DISCONNECTED ?

I'd also add a _STATUS_DISABLED - to inform about the disabled file
transfer on the spice-server. It can be set using
spice_server_set_agent_file_xfer()

https://cgit.freedesktop.org/spice/spice/tree/server/reds.c#n4033

Thanks,
Pavel

> 
> These are only sent to clients that feature
> VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS capability.
> ---
>  spice/vd_agent.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> index 2a168d0..c94395e 100644
> --- a/spice/vd_agent.h
> +++ b/spice/vd_agent.h
> @@ -100,6 +100,8 @@ enum {
>      VD_AGENT_FILE_XFER_STATUS_ERROR,
>      VD_AGENT_FILE_XFER_STATUS_SUCCESS,
>      VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE,
> +    VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED,
> +    VD_AGENT_FILE_XFER_STATUS_NO_AGENT,
>  };
>  
>  typedef struct SPICE_ATTR_PACKED VDAgentFileXferStatusMessage {


More information about the Spice-devel mailing list