[Spice-devel] [PATCH spice-gtk] main: Handle file-xfer detailed errors

[Christophe Fergeau]

Hey,

On Mon, May 29, 2017 at 12:24:46PM +0000, Jakub Janků wrote:
> Hi,
> I copied the message concerning VD_AGENT_FILE_XFER_STATUS_NO_AGENT from the
> linux vdagent. What message would you suggest instead? Perhaps something
> like "Agent not connected, file-xfer cancelled."?

It really depends on who the message is targetted to imo. In the agent
case, it's somethnig which goes into syslog, so most likely meant to
help diagnose some odd issue with the agent. In this case, I would say
the message is fine.

With your change, I would expect the message to be shown to the end user
? If yes, then we need to put more care into it, making sure it's
understandable.
After double-checking virt-viewer code, this seems to be handled in the
task_finished()/hide_transfer_dialog() which only show the error message
in a g_warning(), so this is not that bad.

Regarding your suggestion, maybe "Agent not connected" is enough ?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170529/80ad9e25/attachment.sig>