[Spice-devel] [PATCH spice-gtk v5 3/5] Avoid warning about snprintf on non-Linux platforms

[Frediano Ziglio]

> 
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Without #include <stdio.h>, calls to snprintf in the file
> cause a warning. The file <unistd.h> is left aside on purpose,
> since src/usbutil.c may be compiled on Windows where this
> file does not exist.
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  src/usbutil.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/usbutil.c b/src/usbutil.c
> index b68a2e1..e96ab11 100644
> --- a/src/usbutil.c
> +++ b/src/usbutil.c
> @@ -27,8 +27,8 @@
>  #include <stdlib.h>
>  
>  #ifdef USE_USBREDIR
> -#ifdef __linux__
>  #include <stdio.h>
> +#ifdef __linux__
>  #include <unistd.h>
>  #include <sys/sysmacros.h>
>  #ifndef major /* major and minor macros were moved to sys/sysmacros.h from
>  sys/types.h */

For me is still ack, there was a comment from Christophe Fergeau.

Frediano