[Spice-devel] Role of spice_logger
Frediano Ziglio
fziglio at redhat.com
Tue May 30 15:12:11 UTC 2017
>
> I’m looking at logging functions in log.c, and I wonder why we disable
> logging only at the spice_logger level.
>
> There is a test like this in spice_logger:
>
> if (glib_debug_level != 0) {
> if ((log_level & G_LOG_LEVEL_MASK) > glib_debug_level)
> return; // do not print anything
> }
>
> Shouldn’t put the test in spice_log, so that we don’t do all the formatting
> and allocation if we don’t need it?
>
>
> Christophe
Yes, make sense
Frediano
More information about the Spice-devel
mailing list