[Spice-devel] [PATCH spice-protocol v2] agent: Add new file-xfer statuses

[Pavel Grunt]

Hi Jakub,

you should also list these in the comment describing the data type of
the result (the data type here is "none" but the comment lists results
covered by VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS) - sorry I forgot to
mention that in the first review.

Besides that it looks good to me.

Thanks,
Pavel


On Mon, 2017-05-29 at 16:24 +0200, Jakub Janků wrote:
> Introduce new error statuses to report more info to clients:
> VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED,
> VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED,
> VD_AGENT_FILE_XFER_STATUS_DISABLED
> 
> These are only sent to clients that feature
> VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS capability.
> ---
>  spice/vd_agent.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> index 2a168d0..d5be6f7 100644
> --- a/spice/vd_agent.h
> +++ b/spice/vd_agent.h
> @@ -100,6 +100,9 @@ enum {
>      VD_AGENT_FILE_XFER_STATUS_ERROR,
>      VD_AGENT_FILE_XFER_STATUS_SUCCESS,
>      VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE,
> +    VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED,
> +    VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED,
> +    VD_AGENT_FILE_XFER_STATUS_DISABLED,
>  };
>  
>  typedef struct SPICE_ATTR_PACKED VDAgentFileXferStatusMessage {