[Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

[Frediano Ziglio]

It's used by the build, setting with_coroutine change some conditional
compilation. But this is not in the "Add check for macOS" comment.

I don't see any patch using the OS_MAC conditional, maybe should
be removed or do you want it for coherence with OS_WIN32 ?

Frediano

> 
> Is this used by a patch in this series though? I'd rather we delay this
> until this gets used.
> 
> Christophe
> 
> On Tue, May 30, 2017 at 02:52:47PM +0200, Christophe de Dinechin wrote:
> > From: Christophe de Dinechin <dinechin at redhat.com>
> > 
> > Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> > ---
> >  configure.ac | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index ff00d73..62acafc 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -62,6 +62,18 @@ esac
> >  AC_MSG_RESULT([$os_win32])
> >  AM_CONDITIONAL([OS_WIN32],[test "$os_win32" = "yes"])
> >  
> > +AC_MSG_CHECKING([for native macOS])
> > +case "$host_os" in
> > +     *darwin*)
> > +        os_mac=yes
> > +        ;;
> > +     *)
> > +        os_mac=no
> > +        ;;
> > +esac
> > +AC_MSG_RESULT([$os_mac])
> > +AM_CONDITIONAL([OS_MAC],[test "$os_mac" = "yes"])
> > +
> >  AC_CHECK_HEADERS([sys/socket.h netinet/in.h arpa/inet.h])
> >  AC_CHECK_HEADERS([termios.h])
> >  AC_CHECK_HEADERS([epoxy/egl.h],
> > @@ -468,6 +480,9 @@ esac
> >  if test "$with_coroutine" = "auto"; then
> >    if test "$os_win32" = "yes"; then
> >      with_coroutine=winfiber
> > +  elif test "$os_mac" = "yes"; then
> > +    with_coroutine=ucontext
> > +    AC_DEFINE([_XOPEN_SOURCE], [1], [Define _XOPEN_SOURCE on macOS for
> > ucontext])
> >    else
> >      with_coroutine=ucontext
> >    fi