[Spice-devel] [PATCH v4 3/3] Add configure option for --enable-alignment-checks

Christophe Fergeau cfergeau at redhat.com
Wed May 31 09:22:18 UTC 2017


Small enough that I would squash this with the first patch. If you
want to split things in smaller bits, I think I'd go with a patch
introducing the alignment macro, and one making use of them. This way,
the patch using these macros in spice-gtk does not depend on the patch
using the macros in spice-common being acked first.

Christophe

On Tue, May 30, 2017 at 02:51:51PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  configure.ac | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 6d9f378..efd7317 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -28,6 +28,14 @@ AM_PROG_CC_C_O
>  
>  SPICE_CHECK_SYSDEPS
>  
> +AC_ARG_ENABLE([alignment-checks],
> +  AS_HELP_STRING([--enable-alignment-checks],
> +                 [Enable runtime checks for cast alignment @<:@default=no@:>@]),
> +  [],
> +  enable_alignment_checks="no")
> +AS_IF([test "x$enable_alignment_checks" = "xyes"],
> +      [AC_DEFINE([SPICE_DEBUG_ALIGNMENT], 1, [Enable runtime checks for cast alignment])])
> +
>  # Checks for libraries
>  PKG_CHECK_MODULES([PROTOCOL], [spice-protocol >= 0.12.12])
>  
> -- 
> 2.11.0 (Apple Git-81)
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170531/e2189f49/attachment.sig>


More information about the Spice-devel mailing list