[Spice-devel] [PATCH spice-common] fix indentation on previous patch

Victor Toso victortoso at redhat.com
Wed May 31 14:19:29 UTC 2017


Hi,

On Wed, May 31, 2017 at 03:13:13PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  common/log.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/log.c b/common/log.c
> index bab1afa..7437d3e 100644
> --- a/common/log.c
> +++ b/common/log.c
> @@ -156,7 +156,7 @@ static void spice_logv(const char *log_domain,
>      GLogLevelFlags glib_level = spice_log_level_to_glib(log_level);
>
>      if ((glib_level & G_LOG_LEVEL_MASK) > glib_debug_level) {
> -            return; // do not print anything
> +        return; // do not print anything
>      }

I find it fine for patches that are pending for some time to be reviewed
to be acked+pushed in short period of time.

Other than that a day or so as grace period would avoid this.
Just a small comment, not a big problem either way

Acked-by: Victor Toso <victortoso at redhat.com>


>
>      log_msg = g_string_new(NULL);
> -- 
> 2.9.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170531/d73193b6/attachment-0001.sig>


More information about the Spice-devel mailing list