[Spice-devel] [PATCH v4 1/8] Bump GLib version to 2.34

Christophe de Dinechin christophe.de.dinechin at gmail.com
Tue Nov 7 11:20:09 UTC 2017


Frediano Ziglio writes:

> From: Jakub Janků <janku.jakub.jj at gmail.com>
>
> This is required for the following GMainLoop integration,
> which utilizes some of the new functions/definitions, namely:
>
> [definition][GLib version]
> g_clear_pointer()   2.34
> G_SOURCE_REMOVE     2.32
> G_SOURCE_CONTINUE   2.32
> g_unix_signal_add() 2.30
>
> GLib version accross distributions:
> - Fedora 26  2.52
> - Fedora 25  2.50
> - Fedora 24  2.48
> - CentOS 7   2.46
> - Debian 9   2.50
>
> RHEL 6 is no longer supported.
>
> Acked-by: Frediano Ziglio <fziglio at redhat.com>

Probably a bit late to make that comment, but if we want patchew and
similar tools to work well, we need a way to systematically know which
component a patch applies to, like in other patches in the series.
Otherwise, it's a game of guessing which configure.ac this applies to ;-)

> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index fbc20a9..d92b527 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -85,7 +85,7 @@ AC_ARG_ENABLE([static-uinput],
>                [enable_static_uinput="$enableval"],
>                [enable_static_uinput="no"])
>
> -PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.28])
> +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.34])
>  PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])
>  PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.13])
>  PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22])


--
Cheers,
Christophe de Dinechin (IRC c3d)


More information about the Spice-devel mailing list