[Spice-devel] [PATCH spice-common v2] canvas_base: Allow to specify constant operations

Frediano Ziglio fziglio at redhat.com
Tue Nov 7 11:56:59 UTC 2017


There's no need for the canvas operations to be changed.
This allows without casts to have the operation structures
constants in the code.
This potentially allows to reduce attack surface having some
more data constant instead or read/write.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 common/canvas_base.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Changes since v1:
- fix typo in commit message

diff --git a/common/canvas_base.h b/common/canvas_base.h
index 78e6368..2d3c35b 100644
--- a/common/canvas_base.h
+++ b/common/canvas_base.h
@@ -60,7 +60,7 @@ typedef struct {
 } SpiceImageCacheOps;
 
 struct _SpiceImageCache {
-  SpiceImageCacheOps *ops;
+  const SpiceImageCacheOps *ops;
 };
 
 typedef struct {
@@ -69,7 +69,7 @@ typedef struct {
 } SpiceImageSurfacesOps;
 
 struct _SpiceImageSurfaces {
- SpiceImageSurfacesOps *ops;
+ const SpiceImageSurfacesOps *ops;
 };
 
 typedef struct {
-- 
2.13.6



More information about the Spice-devel mailing list