[Spice-devel] [PATCH spice-server] utils: Fill in all possible channel names

Christophe Fergeau cfergeau at redhat.com
Wed Nov 8 11:32:24 UTC 2017


On Wed, Nov 08, 2017 at 10:31:38AM +0100, Christophe Fergeau wrote:
> Hey,
> 
> On Wed, Nov 08, 2017 at 08:20:12AM +0000, Frediano Ziglio wrote:
> > Missing some names cause some debugging messages to be
> > generated and some of our tests to fail.
> 
> Something I wanted to check before sending this patch is if
> the commit adding human-readable channel did not cause a small
> regression when using spice-server to create a channel whose type is
> not known. This can happen in somehow valid situations, if
> spice-protocol has a new channel type, which code tries to use, when it
> hasn't been added to spice-server yet. I'd even add a test case for that
> actually.

Hmm, ok, while it would be nicer not to have a warning in these cases, I
would say it's acceptable for now as this is unlikely to happen in
practice.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171108/ac63e8cd/attachment.sig>


More information about the Spice-devel mailing list