[Spice-devel] [spice-streaming-agent 3/7] build: Install .pc file to ${libdir}, not ${sharedir}

[Christophe Fergeau]

On Wed, Nov 08, 2017 at 07:09:11AM -0500, Frediano Ziglio wrote:
> > 
> > The .pc file defines a plugin installation location, which will be arch
> > dependent, so the .pc file belongs in this arch ${libdir}, not in the
> > 'noarch' ${sharedir}
> > ---
> >  Makefile.am                   | 2 +-
> >  spice-streaming-agent.spec.in | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 52a8acf..baa9835 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -12,7 +12,7 @@ xdgautostart_DATA =
> > $(top_srcdir)/data/spice-streaming.desktop
> >  gdmautostartdir = $(datadir)/gdm/greeter/autostart
> >  gdmautostart_DATA = $(top_srcdir)/data/spice-streaming.desktop
> >  
> > -pkgconfigdir = $(datadir)/pkgconfig
> > +pkgconfigdir = $(libdir)/pkgconfig
> >  pkgconfig_DATA = spice-streaming-agent.pc
> >  
> >  EXTRA_DIST = \
> > diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> > index 2fefe7c..e472c32 100644
> > --- a/spice-streaming-agent.spec.in
> > +++ b/spice-streaming-agent.spec.in
> > @@ -57,7 +57,7 @@ fi
> >  %files devel
> >  %defattr(-,root,root,-)
> >  %{_includedir}
> > -%{_datadir}/pkgconfig
> > +%{_libdir}/pkgconfig
> >  
> >  %changelog
> >  * Wed Aug 16 2017 Frediano Ziglio <fziglio at redhat.com>
> 
> No %changelog update?

Actually I would not fill the %changelog section in the .spec.in file as
this is version agnostic, @VERSION@ is only substituted later, so I
would not know which NEVR to put there.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171108/dbe9794d/attachment.sig>