[Spice-devel] [spice-streaming-agent 6/7] spec: Use %{buildroot} rather than $RPM_BUILD_ROOT

[Christophe Fergeau]

On Wed, Nov 08, 2017 at 07:07:59AM -0500, Frediano Ziglio wrote:
> Why this is better ?

I'll add this to the commit log, but I find it more obvious this way
that this is an RPM variable, as opposed to something set by the shell.


> 
> > 
> > ---
> >  spice-streaming-agent.spec.in | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> > index e384951..8c4f26e 100644
> > --- a/spice-streaming-agent.spec.in
> > +++ b/spice-streaming-agent.spec.in
> > @@ -34,9 +34,9 @@ agent plugins.
> >  make %{?_smp_mflags} V=1
> >  
> >  %install
> > -make install DESTDIR=$RPM_BUILD_ROOT V=1
> > -if test -d "$RPM_BUILD_ROOT/%{_libdir}/%{name}/plugins"; then
> > -    find $RPM_BUILD_ROOT/%{_libdir}/%{name}/plugins -name '*.la' -delete
> > +make install DESTDIR=%{buildroot} V=1
> > +if test -d "%{buildroot}/%{_libdir}/%{name}/plugins"; then
> > +    find %{buildroot}/%{_libdir}/%{name}/plugins -name '*.la' -delete
> >  fi
> >  
> >  %post
> 
> No %changelog updates ?
> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171108/38ae6502/attachment.sig>