[Spice-devel] [spice-streaming-agent 5/7] spec: Use %autosetup

[Christophe Fergeau]

On Wed, Nov 08, 2017 at 07:44:38AM -0500, Frediano Ziglio wrote:
> > 
> > On Wed, Nov 08, 2017 at 07:15:21AM -0500, Frediano Ziglio wrote:
> > > > 
> > > > This makes patch applying easier, no need to duplicate the information
> > > > in 2 places, a PatchN entry is enough.
> > > > ---
> > > >  spice-streaming-agent.spec.in | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/spice-streaming-agent.spec.in
> > > > b/spice-streaming-agent.spec.in
> > > > index 91e6b88..e384951 100644
> > > > --- a/spice-streaming-agent.spec.in
> > > > +++ b/spice-streaming-agent.spec.in
> > > > @@ -9,6 +9,7 @@ Source0:        %{name}-%{version}.tar.xz
> > > >  BuildRequires:  spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
> > > >  BuildRequires:  libX11-devel libXfixes-devel
> > > >  BuildRequires:  libjpeg-turbo-devel
> > > > +BuildRequires:  git-core
> > > >  # we need /usr/sbin/semanage program which is available on different
> > > >  # packages depending on distribution
> > > >  Requires(post): /usr/sbin/semanage
> > > 
> > > Why git is now needed? I think only if you specify -S git calling
> > > autosetup.
> > 
> > Ah, I forgot to add the -S git_am, but I meant to have it there ;)
> > 
> > Christophe
> > 
> 
> I personally don't agree. Rpm should just do packaging, this git
> integration mainly helps with additional patches which should
> be just upstreamed so to have less patches possible but usually
> if you want to upstream you should work with patches from git master
> not from a spec/rpm/tarball.

Depends, sometimes this really is going to be something distro specific,
for example if you backport the streaming patches to spice-protocol
0.12.13, and thus need to lower the spice-protocol requirement in
spice-streaming-agent configure.ac. I agree most of the time patches
should be upstreamed.

> Also usually if you need additional patches packagers tend to
> have a separate spec file instead of using official one and
> in this case you can have the git_am in the separate spec file.

Well, if the .spec file which is used is as close as possible to the
upstream one, this is better.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171108/8e57cfe7/attachment.sig>