[Spice-devel] [spice-streaming-agent 7/7] spec: Add missing Requires for the -devel package

[Frediano Ziglio]

> 
> On Wed, Nov 08, 2017 at 12:51:01PM +0100, Christophe Fergeau wrote:
> > It needs the corresponding library to be installed, as well as
> > pkg-config since it installs a .pc file.
> > ---
> > Since the plugins are going to be dlopened, and since the main package
> > does not ship a .so we need to link to, I'm unsure about the first
> > Requires this patch adds.
> 
> FYI, the explicitly versioned requires from -devel to the base RPM is
> mandated
> by Fedora packaging rules
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> 
>   "It is almost always better to over specify the version, so it is best
>    practice to just use a fully versioned dependency:
>     Requires: %{name}%{?_isa} = %{version}-%{release}.
>    Devel packages are an example of a package that must require their base
>    packages using a fully versioned dependency."
> 

Maybe is just me but I read this as "when you need to depend from the main
package you must use a versioned dependency", not "you must depend on the
main package".

> >  spice-streaming-agent.spec.in | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> > index 8c4f26e..351de11 100644
> > --- a/spice-streaming-agent.spec.in
> > +++ b/spice-streaming-agent.spec.in
> > @@ -20,6 +20,8 @@ An agent, running on a guest, sending video streams of
> > the X display to a remote
> >  
> >  %package devel
> >  Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
> > +Requires: %{name}%{?_isa} = %{version}-%{release}
> > +Requires: pkgconfig
> >  Summary:  SPICE streaming agent development files
> >  
> >  %description devel
> > --
> > 2.13.6
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> Regards,
> Daniel

Frediano