[Spice-devel] [spice-streaming-agent 2/2] build: Don't use * wildcard in Makefile.am

Frediano Ziglio fziglio at redhat.com
Thu Nov 9 11:19:56 UTC 2017


> 
> automake does not support this,
> see https://www.gnu.org/software/automake/manual/html_node/Wildcards.html
> and this was causing weird failures when running make distcheck
> (automake looking for *.in files in $builddir rather than $srcdir, and
> then an unwanted hexdump\*.out file created in $builddir, but not
> cleaned).
> ---
>  src/unittests/Makefile.am | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/unittests/Makefile.am b/src/unittests/Makefile.am
> index 1a5f339..ba3edc0 100644
> --- a/src/unittests/Makefile.am
> +++ b/src/unittests/Makefile.am
> @@ -33,4 +33,11 @@ test_hexdump_LDADD = \
>  	../libstreaming-utils.a \
>  	$(NULL)
>  
> -EXTRA_DIST = hexdump.sh hexdump*.in hexdump*.out
> +EXTRA_DIST = \
> +	hexdump.sh \
> +	hexdump1.in \
> +	hexdump1.out \
> +	hexdump2.in \
> +	hexdump2.out \
> +	hexdump3.in \
> +	hexdump3.out

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list