[Spice-devel] [PATCH spice-streaming-agent] Use RAII to cleanup stream in case of exception or return

[Frediano Ziglio]

... omissis ...

> > 
> >> @@ -441,7 +448,7 @@ int main(int argc, char* argv[])
> >>     if (isatty(fileno(stderr)) && isatty(fileno(stdin))) {
> >>         stdin_ok = true;
> >>     }
> >> -
> >> +
> >>     openlog("spice-streaming-agent", stdin_ok? (LOG_PERROR|LOG_PID) :
> >>     LOG_PID, LOG_USER);
> >>     setlogmask(logmask);
> >> 
> >> @@ -526,4 +533,3 @@ int main(int argc, char* argv[])
> >>     closelog();
> >>     return ret;
> >> }
> >> -
> > 
> > I would remove these spurious changes.
> 
> My emacs is configured to remove trailing spaces and empty lines at end of
> file automatically. Line 444 of the master I was working on
> (a61a00f12e1f8e1b982441bb4571376e3b2262e1) has trailing spaces, and there is
> an empty line at end of file. Can we agree that such cleanup is OK?
> 

If the rationale is just "my environment is configured that way" I would
say no. As they are changing just empty lines which people interested
in an annotate/blame command won't care I personally would accept a style
cleanup patch.

Frediano