[Spice-devel] [PATCH] usbredirserver: use more popular name instead of usbbus-usbaddr

[Marc-André Lureau]

Hi

----- Original Message -----
> From: Chen Hanxiao <chenhanxiao at gmail.com>
> 
>   Usually we use busnum:devnum for a usb device.
>   Tools such as lsusb, udev did that.
>   Our original naming is a little confued.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau at redhat.com>

> ---
>  usbredirserver/usbredirserver.1 | 2 +-
>  usbredirserver/usbredirserver.c | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/usbredirserver/usbredirserver.1
> b/usbredirserver/usbredirserver.1
> index b36debc..e857190 100644
> --- a/usbredirserver/usbredirserver.1
> +++ b/usbredirserver/usbredirserver.1
> @@ -3,7 +3,7 @@
>  usbredirserver \- exporting an USB device for use from another (virtual)
>  machine
>  .SH SYNOPSIS
>  .B usbredirserver
> -[\fI-p|--port <port>\fR] [\fI-v|--verbose <0-5>\fR]
> \fI<usbbus-usbaddr|vendorid:prodid>\fR
> +[\fI-p|--port <port>\fR] [\fI-v|--verbose <0-5>\fR]
> \fI<busnum-devnum|vendorid:prodid>\fR
>  .SH DESCRIPTION
>  usbredirserver is a small standalone server for exporting an USB device for
>  use from another (virtual) machine through the usbredir protocol.
> diff --git a/usbredirserver/usbredirserver.c
> b/usbredirserver/usbredirserver.c
> index ff773ed..13965dc 100644
> --- a/usbredirserver/usbredirserver.c
> +++ b/usbredirserver/usbredirserver.c
> @@ -93,7 +93,7 @@ static int usbredirserver_write(void *priv, uint8_t *data,
> int count)
>  static void usage(int exit_code, char *argv0)
>  {
>      fprintf(exit_code? stderr:stdout,
> -        "Usage: %s [-p|--port <port>] [-v|--verbose <0-5>]
> <usbbus-usbaddr|vendorid:prodid>\n",
> +        "Usage: %s [-p|--port <port>] [-v|--verbose <0-5>]
> <busnum-devnum|vendorid:prodid>\n",
>          argv0);
>      exit(exit_code);
>  }
> @@ -341,12 +341,12 @@ int main(int argc, char *argv[])
>              if (i < n) {
>                  if (libusb_open(list[i], &handle) != 0) {
>                      fprintf(stderr,
> -                        "Could not open usb-device at bus-addr %d-%d\n",
> +                        "Could not open usb-device at busnum-devnum
> %d-%d\n",
>                          usbbus, usbaddr);
>                  }
>              } else {
>                  fprintf(stderr,
> -                    "Could not find an usb-device at bus-addr %d-%d\n",
> +                    "Could not find an usb-device at busnum-devnum %d-%d\n",
>                      usbbus, usbaddr);
>              }
>              libusb_free_device_list(list, 1);
> --
> 2.13.6
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>