[Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

[Frediano Ziglio]

> 
> Hi,
> 
> On Tue, Nov 14, 2017 at 04:41:46PM +0100, Christophe de Dinechin wrote:
> > 
> > 
> > > On 14 Nov 2017, at 16:22, Frediano Ziglio <fziglio at redhat.com> wrote:
> > > 
> > >> 
> > >> From: Christophe de Dinechin <dinechin at redhat.com>
> > >> 
> > >> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> > >> ---
> > >> include/spice-streaming-agent/plugin.hpp | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >> 
> > >> diff --git a/include/spice-streaming-agent/plugin.hpp
> > >> b/include/spice-streaming-agent/plugin.hpp
> > >> index 727cb3b..607fabf 100644
> > >> --- a/include/spice-streaming-agent/plugin.hpp
> > >> +++ b/include/spice-streaming-agent/plugin.hpp
> > >> @@ -26,7 +26,7 @@ class FrameCapture;
> > >>  * where MM is major and mm is the minor, can be easily expanded
> > >>  * using more bits in the future
> > >>  */
> > >> -enum Constants : unsigned { PluginVersion = 0x100u };
> > >> +enum Constants : unsigned { PluginVersion = 0x001u };
> > >> 
> > >> enum Ranks : unsigned {
> > >>     /// this plugin should not be used
> > > 
> > > Nack... ABI not compatible
> > 
> > Precisely. We should not have started at 1.0. I think it’s still time to
> > fix it.
> > 
> > Christophe
> 
> Note that spice-gtk is 7 years old, 2399 commits and still on 0.34
> release ;)
> 
> Shouldn't be a problem to go to 2.0 afterwards, etc.
> 
> Cheers,
>         toso
> 

You are confusing ABI version and software version, spice-gtk is 5.0.0 (ABI).

Frediano