[Spice-devel] [PATCH spice-server] stream-channel: Tell client we are just streaming data

[Frediano Ziglio]

> 
> On Mon, Nov 13, 2017 at 03:47:43PM +0000, Frediano Ziglio wrote:
> > This give an hint to client which can optimise rendering.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/stream-channel.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/server/stream-channel.c b/server/stream-channel.c
> > index c7ca0206..67784711 100644
> > --- a/server/stream-channel.c
> > +++ b/server/stream-channel.c
> > @@ -203,6 +203,12 @@ stream_channel_send_item(RedChannelClient *rcc,
> > RedPipeItem *pipe_item)
> >              channel->width, channel->height,
> >              SPICE_SURFACE_FMT_32_xRGB, SPICE_SURFACE_FLAGS_PRIMARY
> >          };
> > +#ifdef SPICE_SURFACE_FLAGS_STREAMING_MODE
> > +        // give an hint to client that we are sending just streaming
> > +        if (red_channel_client_test_remote_cap(rcc,
> > SPICE_DISPLAY_CAP_MULTI_CODEC)) {
> > +            surface_create.flags |= SPICE_SURFACE_FLAGS_STREAMING_MODE;
> > +        }
> 
> I would add an explanation to the commit log as to why we can use the
> SPICE_DISPLAY_CAP_MULTI_CODEC
> capability here. Or is this already explained in another commit?
> 
> Christophe
> 

Is in spice.proto but a comment referring to it does not surely hurt

Frediano