[Spice-devel] [PATCH spice-server v2] stream-channel: Tell client we are just streaming data

[Christophe de Dinechin]

Frediano Ziglio writes:

> This give an hint to client which can optimise rendering.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/stream-channel.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> Changes since v1:
> - add a comment for capability check explanation
>
> diff --git a/server/stream-channel.c b/server/stream-channel.c
> index c7ca0206..e686fe4d 100644
> --- a/server/stream-channel.c
> +++ b/server/stream-channel.c
> @@ -203,6 +203,13 @@ stream_channel_send_item(RedChannelClient *rcc, RedPipeItem *pipe_item)
>              channel->width, channel->height,
>              SPICE_SURFACE_FMT_32_xRGB, SPICE_SURFACE_FLAGS_PRIMARY
>          };
> +#ifdef SPICE_SURFACE_FLAGS_STREAMING_MODE

Is that an example of how you would use your identity macros?

> +        // give an hint to client that we are sending just streaming
> +        // see spice.proto for capability check here
> +        if (red_channel_client_test_remote_cap(rcc, SPICE_DISPLAY_CAP_MULTI_CODEC)) {
> +            surface_create.flags |= SPICE_SURFACE_FLAGS_STREAMING_MODE;
> +        }
> +#endif
>          spice_marshall_msg_display_surface_create(m, &surface_create);
>          break;
>      }


--
Cheers,
Christophe de Dinechin (IRC c3d)