[Spice-devel] [PATCH spice-streaming-agent v2 2/2] Rework option handling

[Christophe Fergeau]

On Thu, Nov 16, 2017 at 10:17:28AM -0500, Frediano Ziglio wrote:
> > 4. It delegates usage information to the plugins, so that each plugin
> >    can document its specific options in a consistent way.
> > 
> > 5. It cleans up some confusing or surprising aspects of the interace,
> >    notably null-terminated option vectors and the ownership of
> >    dynamically loaded plugins.
> > 
> > Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> 
> Maybe you should split the patch instead of having multiple points
> inside the comment? I would personally starts with some commit that
> can be merged without waiting, like adding a Name() method.

Yes, that was my reaction when reading through it, this is trying to do far too
much in one commit.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171121/dc963f18/attachment.sig>