[Spice-devel] [PATCH usbredir] usbredirserver: reject empty vendor id in cmd line

Chen Hanxiao chen_han_xiao at 126.com
Tue Nov 28 09:17:52 UTC 2017


From: Chen Hanxiao <chenhanxiao at gmail.com>

Vendor ID 0000 is not a valid ID [1]
But we could pass it from cmd:
  usbredirserver :abcd
   or
  usbredirserver 0000:abcd

Which will pass a 0000 vendor id to usbredirserver.

This patch will check this senario.

[1]: http://www.linux-usb.org/usb.ids

Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>
---
 usbredirserver/usbredirserver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usbredirserver/usbredirserver.c b/usbredirserver/usbredirserver.c
index 5a4adc5..17226a5 100644
--- a/usbredirserver/usbredirserver.c
+++ b/usbredirserver/usbredirserver.c
@@ -259,7 +259,7 @@ int main(int argc, char *argv[])
             invalid_usb_device_id(argv[optind], argv[0]);
         }
         usbvendor = strtol(argv[optind], &endptr, 16);
-        if (*endptr != ':') {
+        if (*endptr != ':' || usbvendor == 0) {
             invalid_usb_device_id(argv[optind], argv[0]);
         }
         usbproduct = strtol(delim + 1, &endptr, 16);
-- 
2.14.3



More information about the Spice-devel mailing list