[Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

[Jakub Janků]

On Thu, Nov 30, 2017 at 6:24 PM, Frediano Ziglio <fziglio at redhat.com> wrote:

>
> > On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau <
> cfergeau at redhat.com >
> > wrote:
> > > On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote:
> > >> This is a preparatory patch for GTK+ vdagent redesign.
> > >>
> > >> Since most of the vdagent code still uses X11 lib,
> > >> force GDK to use X11 backend by calling
> > >> gdk_set_allowed_backends("x11").
> > >
> > > What happens if the agent tries to use gtk+, and this call is not
> > > present?
> > >
> > > Christophe
>
> > I'll fix this in the next version, I was waiting for reviews of the other
> > patches (2/3, 3/3).
>
> > gdk_set_allowed_backends() was added in v3.10. Prior to this version,
> > GDK_IS_X11_DISPLAY() should be used after gtk_init() to make sure we are
> > using X11.
> > Or would anyone be against requiring GTK+ v3.10?
>
> > Cheers,
> > Jakub
>
> According to https://github.com/FreeRDP/Remmina/wiki/GTK-versions-on-
> various-distributions
> no RHEL7 then (wheezy and precise are in theory supported even in 2018).
>

OK then, I will use GDK_IS_X11_DISPLAY() and terminate the program when
this check fails.

>
> Should not we have
>
> PKG_CHECK_MODULES([GTK], [gtk+-3.0 >= 3.10])
>
> ?
>

What do you mean by this?

>
> Frediano
>

Jakub
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171130/109dbb2d/attachment.html>