[Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

[janku.jakub.jj at gmail.com]

On Thu, 2017-11-30 at 13:06 -0500, Frediano Ziglio wrote:
> > On Thu, Nov 30, 2017 at 6:24 PM, Frediano Ziglio < fziglio at redhat.c
> > om >
> > wrote:
> > > > On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau < cfergeau@
> > > > redhat.com
> > > > > 
> > > > wrote:
> > > > > On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote:
> > > > > > This is a preparatory patch for GTK+ vdagent redesign.
> > > > > > 
> > > > > > Since most of the vdagent code still uses X11 lib,
> > > > > > force GDK to use X11 backend by calling
> > > > > > gdk_set_allowed_backends("x11").
> > > > > 
> > > > > What happens if the agent tries to use gtk+, and this call is
> > > > > not
> > > > > present?
> > > > > 
> > > > > Christophe
> > > > I'll fix this in the next version, I was waiting for reviews of
> > > > the other
> > > > patches (2/3, 3/3).
> > > > gdk_set_allowed_backends() was added in v3.10. Prior to this
> > > > version,
> > > > GDK_IS_X11_DISPLAY() should be used after gtk_init() to make
> > > > sure we are
> > > > using X11.
> > > > Or would anyone be against requiring GTK+ v3.10?
> > > > Cheers,
> > > > Jakub
> > > According to
> > > https://github.com/FreeRDP/Remmina/wiki/GTK-versions-on-various-d
> > > istributions
> > > no RHEL7 then (wheezy and precise are in theory supported even in
> > > 2018).
> > OK then, I will use GDK_IS_X11_DISPLAY() and terminate the program
> > when this
> > check fails.
> > > Should not we have
> > > PKG_CHECK_MODULES([GTK], [gtk+-3.0 >= 3.10])
> > > ?
> > What do you mean by this?
> > Jakub
> 
> Yes, the 2 suggestions seem to conflict. I'm not sure about the page
> I pointed out. For instance I just checked RHEL 7.4 and there's gtk
> 3.22
> so is fine, maybe the page is referring at the first release, not
> sure
> if we should support still RHEL 7.0.
> Maybe we can assume there's at least gtk 3.10.
> 
> --
> Frediano
> 
> OT: Please try to reply using text format, not html.
> 
Btw spice-gtk requires gtk 3.10 since March 2016.

Sorry about the html,
Jakub