[Spice-devel] [PATCH spice-server] red-channel: Remove red_channel_init_outgoing_messages_window

[Christophe Fergeau]

On Fri, Oct 06, 2017 at 11:58:32AM +0100, Frediano Ziglio wrote:
> This function does not make much sense anymore.
> Is called by RedVmcChannel which doesn't use RedChannelClient ACKs
> so the variable changed are not used.


> Also is called when the channel is constructed to set client
> fields however at that stage there are no clients.

I'm not seeing this channel construction code in master?

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> Note that now red_channel_client_init_outgoing_messages_window
> is not used anymore.
> On the other hand this function is really similar to
> red_channel_client_ack_zero_messages_window but IMHO has a better
> name. Would prefer a follow up to unify
> red_channel_client_init_outgoing_messages_window and
> red_channel_client_ack_zero_messages_window names and behaviour.

Would definitely make sense, especially as I'm not convinced
smartcard.c/spicevmc.c should call
red_channel_client_ack_zero_messages_window() as they don't handle acks.

Looks good to me,
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171012/006f4be9/attachment.sig>