[Spice-devel] [PATCH spice-server] red-channel: Remove red_channel_init_outgoing_messages_window

[Christophe Fergeau]

On Thu, Oct 12, 2017 at 11:06:02AM -0400, Frediano Ziglio wrote:
> > 
> > On Fri, Oct 06, 2017 at 11:58:32AM +0100, Frediano Ziglio wrote:
> > > This function does not make much sense anymore.
> > > Is called by RedVmcChannel which doesn't use RedChannelClient ACKs
> > > so the variable changed are not used.
> > 
> > 
> > > Also is called when the channel is constructed to set client
> > > fields however at that stage there are no clients.
> > 
> > I'm not seeing this channel construction code in master?
> > 
> 
> I'm referring to red_vmc_channel_constructed code. Maybe
> I should specify the channel? Is in the previous paragraph.

Ah, I did not realize your 'Also' was adding more details to the
beginning of the sentence. I thought you were referring to a different
location in the code, one use is in RedVmcChannel, and another use in
RedChannel::constructed or wherever.
Maybe change it to "Moreover, at red_vmc_channel_constructed() time,
there will be no clients yet, so red_channel_init_outgoing_messages()
will be a no-op".

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171012/cf85f3cc/attachment.sig>