[Spice-devel] [PATCH spice-server 1/2] build-sys: Fix syntax-check

Jonathon Jongsma jjongsma at redhat.com
Fri Sep 1 19:00:12 UTC 2017


OK. I guess this is a portability thing?

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Fri, 2017-09-01 at 10:32 +0100, Frediano Ziglio wrote:
> This error was reported
> 
> configure.ac:119:if test "x$have_gstreamer_0_10" = "xyes" -o
> "x$have_gstreamer_1_0" = "xyes"; then
> maint.mk: use "test C1 && test C2", not "test C1 -a C2"; use "test C1
> || test C2", not "test C1 -o C2"
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index f80193b3..7d8afd57 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -116,7 +116,7 @@ AS_IF([test x"$missing_gstreamer_elements" =
> xyes],
>      [SPICE_WARNING([The GStreamer video encoder can be built but may
> not work.])
>  ])
>  
> -if test "x$have_gstreamer_0_10" = "xyes" -o "x$have_gstreamer_1_0" =
> "xyes"; then
> +if test "x$have_gstreamer_0_10" = "xyes" || test
> "x$have_gstreamer_1_0" = "xyes"; then
>      PKG_CHECK_MODULES(ORC, orc-0.4)
>      AC_SUBST(ORC_CFLAGS)
>      AC_SUBST(ORC_LIBS)


More information about the Spice-devel mailing list