[Spice-devel] [PATCH spice-server 2/5] tests: Pass command list as constant

[Jonathon Jongsma]

OK

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Fri, 2017-09-01 at 15:12 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/tests/test-display-base.c   | 2 +-
>  server/tests/test-display-base.h   | 2 +-
>  server/tests/test-display-no-ssl.c | 2 +-
>  server/tests/test-two-servers.c    | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/server/tests/test-display-base.c b/server/tests/test-
> display-base.c
> index 6d70da08..d95f19f5 100644
> --- a/server/tests/test-display-base.c
> +++ b/server/tests/test-display-base.c
> @@ -864,7 +864,7 @@ void test_add_agent_interface(SpiceServer
> *server)
>      spice_server_add_interface(server, &vdagent_sin.base);
>  }
>  
> -void test_set_simple_command_list(Test *test, int *simple_commands,
> int num_commands)
> +void test_set_simple_command_list(Test *test, const int
> *simple_commands, int num_commands)
>  {
>      int i;
>  
> diff --git a/server/tests/test-display-base.h b/server/tests/test-
> display-base.h
> index f4231359..1a4f20c5 100644
> --- a/server/tests/test-display-base.h
> +++ b/server/tests/test-display-base.h
> @@ -130,7 +130,7 @@ struct Test {
>      void (*on_client_disconnected)(Test *test);
>  };
>  
> -void test_set_simple_command_list(Test *test, int *command, int
> num_commands);
> +void test_set_simple_command_list(Test *test, const int *command,
> int num_commands);
>  void test_set_command_list(Test *test, Command *command, int
> num_commands);
>  void test_add_display_interface(Test *test);
>  void test_add_agent_interface(SpiceServer *server); // TODO - Test
> *test
> diff --git a/server/tests/test-display-no-ssl.c b/server/tests/test-
> display-no-ssl.c
> index ad2aece3..597d1401 100644
> --- a/server/tests/test-display-no-ssl.c
> +++ b/server/tests/test-display-no-ssl.c
> @@ -42,7 +42,7 @@ static void pinger(SPICE_GNUC_UNUSED void *opaque)
>      core->timer_start(ping_timer, ping_ms);
>  }
>  
> -int simple_commands[] = {
> +static const int simple_commands[] = {
>      //SIMPLE_CREATE_SURFACE,
>      //SIMPLE_DRAW,
>      //SIMPLE_DESTROY_SURFACE,
> diff --git a/server/tests/test-two-servers.c b/server/tests/test-two-
> servers.c
> index b103d54c..e9f4205c 100644
> --- a/server/tests/test-two-servers.c
> +++ b/server/tests/test-two-servers.c
> @@ -25,7 +25,7 @@
>  
>  SpiceCoreInterface *core;
>  
> -int simple_commands[] = {
> +static const int simple_commands[] = {
>      //SIMPLE_CREATE_SURFACE,
>      //SIMPLE_DRAW,
>      //SIMPLE_DESTROY_SURFACE,