[Spice-devel] [PATCH spice-server 3/5] tests: Avoid leaking list of commands

Jonathon Jongsma jjongsma at redhat.com
Fri Sep 1 22:02:03 UTC 2017


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Fri, 2017-09-01 at 15:12 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/tests/test-display-base.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/server/tests/test-display-base.c b/server/tests/test-
> display-base.c
> index d95f19f5..d01fb36b 100644
> --- a/server/tests/test-display-base.c
> +++ b/server/tests/test-display-base.c
> @@ -868,7 +868,7 @@ void test_set_simple_command_list(Test *test,
> const int *simple_commands, int nu
>  {
>      int i;
>  
> -    /* FIXME: leaks */
> +    free(test->commands);
>      test->commands = malloc(sizeof(*test->commands) * num_commands);
>      memset(test->commands, 0, sizeof(*test->commands) *
> num_commands);
>      test->num_commands = num_commands;
> @@ -914,6 +914,7 @@ void test_destroy(Test *test)
>  {
>      test->core->timer_remove(test->wakeup_timer);
>      spice_server_destroy(test->server);
> +    free(test->commands);
>      free(test);
>  }
>  


More information about the Spice-devel mailing list