[Spice-devel] [PATCH spice-server 4/5] tests: Remove unused declarations

Jonathon Jongsma jjongsma at redhat.com
Fri Sep 1 22:02:32 UTC 2017


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Fri, 2017-09-01 at 15:12 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/tests/test-display-no-ssl.c             | 5 -----
>  server/tests/test-display-resolution-changes.c | 4 ----
>  server/tests/test-display-width-stride.c       | 4 ----
>  server/tests/test-vdagent.c                    | 5 -----
>  4 files changed, 18 deletions(-)
> 
> diff --git a/server/tests/test-display-no-ssl.c b/server/tests/test-
> display-no-ssl.c
> index 597d1401..5a2fd2f4 100644
> --- a/server/tests/test-display-no-ssl.c
> +++ b/server/tests/test-display-no-ssl.c
> @@ -30,15 +30,10 @@
>  SpiceCoreInterface *core;
>  SpiceTimer *ping_timer;
>  
> -void show_channels(SpiceServer *server);
> -
>  int ping_ms = 100;
>  
>  static void pinger(SPICE_GNUC_UNUSED void *opaque)
>  {
> -    // show_channels is not thread safe - fails if disconnections /
> connections occur
> -    //show_channels(server);
> -
>      core->timer_start(ping_timer, ping_ms);
>  }
>  
> diff --git a/server/tests/test-display-resolution-changes.c
> b/server/tests/test-display-resolution-changes.c
> index e9eccbe2..b247c97c 100644
> --- a/server/tests/test-display-resolution-changes.c
> +++ b/server/tests/test-display-resolution-changes.c
> @@ -26,15 +26,11 @@
>  
>  SpiceTimer *ping_timer;
>  
> -void show_channels(SpiceServer *server);
> -
>  int ping_ms = 100;
>  
>  static void pinger(void *opaque)
>  {
>      Test *test = opaque;
> -    // show_channels is not thread safe - fails if disconnections /
> connections occur
> -    //show_channels(server);
>  
>      test->core->timer_start(ping_timer, ping_ms);
>  }
> diff --git a/server/tests/test-display-width-stride.c
> b/server/tests/test-display-width-stride.c
> index 0100e1de..778bbd77 100644
> --- a/server/tests/test-display-width-stride.c
> +++ b/server/tests/test-display-width-stride.c
> @@ -26,15 +26,11 @@
>  
>  SpiceTimer *ping_timer;
>  
> -void show_channels(SpiceServer *server);
> -
>  int ping_ms = 100;
>  
>  static void pinger(void *opaque)
>  {
>      Test *test = opaque;
> -    // show_channels is not thread safe - fails if disconnections /
> connections occur
> -    //show_channels(server);
>  
>      test->core->timer_start(ping_timer, ping_ms);
>  }
> diff --git a/server/tests/test-vdagent.c b/server/tests/test-
> vdagent.c
> index 232e9824..01308d0d 100644
> --- a/server/tests/test-vdagent.c
> +++ b/server/tests/test-vdagent.c
> @@ -29,11 +29,6 @@
>  #include "test-display-base.h"
>  #include "test-glib-compat.h"
>  
> -SpiceCoreInterface *core;
> -SpiceTimer *ping_timer;
> -
> -int ping_ms = 100;
> -
>  #ifndef MIN
>  #define MIN(a, b) ((a) > (b) ? (b) : (a))
>  #endif


More information about the Spice-devel mailing list