[Spice-devel] [spice-server 1/3] channel: Call red_channel_disconnect_if_pending_send() from red_channel_wait_all_sent()

Christophe Fergeau cfergeau at redhat.com
Mon Sep 4 06:59:46 UTC 2017


On Fri, Sep 01, 2017 at 06:19:28AM -0400, Frediano Ziglio wrote:
> > 
> > red_channel_disconnect_if_pending_send() and red_channel_wait_all_sent() are
> > always called together, we can remove one of the 2 methods.
> > 
> 
> Looks a good idea but I think that the function deserve a new name

I would not know how to change the name though :-/

> 
> Did you notice the function is always called with the same second parameter?
> Does it make sense to pass it?

Ah no, I did not pay attention to that at all, I'll take a closer look
;)

Christophe


More information about the Spice-devel mailing list