[Spice-devel] [PATCH spice-server 2/2] Reuse GOBJECT_DECLARE_TYPE* macros

Frediano Ziglio fziglio at redhat.com
Wed Sep 6 14:46:05 UTC 2017


> 
> On Mon, Sep 04, 2017 at 05:09:23PM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/char-device.c              |  2 +-
> >  server/char-device.h              | 14 +-----
> >  server/common-graphics-channel.h  | 40 ++--------------
> >  server/cursor-channel-client.h    | 18 +------
> >  server/cursor-channel.h           | 13 +-----
> >  server/dcc.h                      | 18 +------
> >  server/dispatcher.h               | 13 +-----
> >  server/display-channel.h          | 16 +------
> >  server/inputs-channel-client.h    | 18 +------
> >  server/inputs-channel.h           | 14 +-----
> >  server/main-channel-client.h      | 18 +------
> >  server/main-channel.h             | 14 +-----
> >  server/main-dispatcher.h          | 13 +-----
> >  server/red-channel-client.h       | 17 +------
> >  server/red-channel.h              | 19 ++------
> >  server/red-client.h               | 13 +-----
> >  server/reds.c                     | 12 +----
> >  server/smartcard-channel-client.h | 18 +------
> >  server/smartcard.c                | 19 +-------
> >  server/smartcard.h                | 12 +----
> >  server/sound.c                    | 77 +++++++++++++-----------------
> >  server/spicevmc.c                 | 98
> >  ++++++++++++---------------------------
> >  22 files changed, 86 insertions(+), 410 deletions(-)
> > 
> > diff --git a/server/char-device.c b/server/char-device.c
> > index 658f9f36..a00c29f4 100644
> > --- a/server/char-device.c
> > +++ b/server/char-device.c
> > @@ -697,7 +697,7 @@ void red_char_device_reset_dev_instance(RedCharDevice
> > *dev,
> >  
> >  void red_char_device_destroy(RedCharDevice *char_dev)
> >  {
> > -    g_return_if_fail(RED_IS_CHAR_DEVICE(char_dev));
> > +    g_return_if_fail(IS_RED_CHAR_DEVICE(char_dev));
> 
> Nope, RED being our namespace, RED_IS_CHAR_DEVICE is correct
> (gtk uses GTK_IS_WIDGET, not IS_GTK_WIDGET)
> 
> Christophe
> 

Fixed

Frediano


More information about the Spice-devel mailing list