[Spice-devel] [PATCH spice-server 03/10] reds-stream: Remove shutdown field

Christophe Fergeau cfergeau at redhat.com
Mon Sep 11 16:12:34 UTC 2017


On Mon, Sep 11, 2017 at 11:56:45AM -0400, Frediano Ziglio wrote:
> > 
> > 
> > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > 
> > On Mon, Sep 11, 2017 at 11:15:40AM +0100, Frediano Ziglio wrote:
> > > This field was used only by RedChannelClient to mark when the
> > > socket was shutdown. This condition can simply be tested by
> > > RedChannelClient checking if there's a watch as is the only
> > > condition (beside object destroying) where the watch is removed.
> > 
> > It's removed on red_channel_client_disconnect(), dunno if that's what
> > you call "object destroying"
> > 
> 
> After a disconnection the object should be destroyed.
> 
> I could update to
> 
> ...condition (beside object destroying/disconnecting) where the watch is removed.

Fine with me, thanks.

Christophe

> 
> Frediano


More information about the Spice-devel mailing list