[Spice-devel] [PATCH spice-server 1/3] test-gst: Remove useless check

Christophe Fergeau cfergeau at redhat.com
Mon Sep 11 16:28:40 UTC 2017


On Mon, Sep 11, 2017 at 09:12:16AM +0100, Frediano Ziglio wrote:
> encoder_name is never NULL as already initialized with "mjpeg" value.

Note that this is going to be changed in patch 3/3

Christophe

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/tests/test-gst.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/server/tests/test-gst.c b/server/tests/test-gst.c
> index d4ebaacf6..40f738d78 100644
> --- a/server/tests/test-gst.c
> +++ b/server/tests/test-gst.c
> @@ -368,11 +368,6 @@ int main(int argc, char *argv[])
>          exit(1);
>      }
>  
> -    if (!encoder_name) {
> -        g_printerr("Encoder name option missing\n");
> -        exit(1);
> -    }
> -
>      const EncoderInfo *encoder = get_encoder_info(encoder_name);
>      if (!encoder) {
>          g_printerr("Encoder name unsupported: %s\n", encoder_name);
> -- 
> 2.13.5
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list