[Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

[Frediano Ziglio]

> 
> On Mon, Sep 11, 2017 at 09:12:17AM +0100, Frediano Ziglio wrote:
> > These leaks are detected for instance by address sanitizer.
> 
> More details about what these leaks are would be welcome...
> I can guess what these are, but the commit log is really where this
> belongs.
> 
> 
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/tests/test-gst.c | 18 ++++++++++++------
> >  1 file changed, 12 insertions(+), 6 deletions(-)
> > 
> > diff --git a/server/tests/test-gst.c b/server/tests/test-gst.c
> > index 40f738d78..224a891b1 100644
> > --- a/server/tests/test-gst.c
> > +++ b/server/tests/test-gst.c
> > @@ -314,11 +314,11 @@ static const EncoderInfo encoder_infos[] = {
> >  int main(int argc, char *argv[])
> >  {
> >      gchar *input_pipeline_desc = NULL;
> > -    const gchar *image_format = "32BIT";
> > -    const gchar *encoder_name = "mjpeg";
> > +    gchar *image_format = NULL;
> > +    gchar *encoder_name = NULL;
> >      gchar *file_report_name = NULL;
> >      gboolean use_hw_encoder = FALSE; // TODO use
> > -    const gchar *clipping = "(0,0)x(100%,100%)";
> > +    gchar *clipping = NULL;
> >  
> >      // - input pipeline
> >      // - top/down
> > @@ -368,19 +368,19 @@ int main(int argc, char *argv[])
> >          exit(1);
> >      }
> >  
> > -    const EncoderInfo *encoder = get_encoder_info(encoder_name);
> > +    const EncoderInfo *encoder = get_encoder_info(encoder_name ?
> > encoder_name : "mjpeg");
> >      if (!encoder) {
> >          g_printerr("Encoder name unsupported: %s\n", encoder_name);
> 
> This is going to be "Encoder name unsupported: (null)" when the
> corresponding option is not given, ditto for the other options that you
> changed.
> 

No, the defaults are present so encoder won't be NULL... but I can change
the code to make this more clear.

> Christophe
> 

Frediano