[Spice-devel] [PATCH spice-server 10/10] tests: Avoid to disable all deprecation warnings just for expect functions

[Christophe Fergeau]

On Tue, Sep 12, 2017 at 03:48:06AM -0400, Frediano Ziglio wrote:
> > > +static inline void
> > > +g_test_assert_expected_messages_internal_no_warnings(const char *domain,
> > > +                                                     const char *file, int
> > > line, const char *func)
> > > +{
> > > +    G_GNUC_BEGIN_IGNORE_DEPRECATIONS
> > > +    g_test_assert_expected_messages_internal(domain, file, line, func);
> > > +    G_GNUC_END_IGNORE_DEPRECATIONS
> > > +}
> > > +#define g_test_expect_message g_test_expect_message_no_warnings
> > > +#define g_test_assert_expected_messages_internal
> > > g_test_assert_expected_messages_internal_no_warnings
> > 
> > I don't understand why you define g_test_assert_expected_messages_internal?
> > The glib < 2.34 case has
> > #define g_test_assert_expected_messages() \
> >     g_test_assert_expected_messages_internal (G_LOG_DOMAIN, __FILE__,
> >     __LINE__, G_STRFUNC)
> > but I see no such #define in the newer glib case?
> > 
> 
> Is defined by GLib itself.

I would say this all belongs in the commit log rather than having
everyone go look for the explanation themselves.

Christophe