[Spice-devel] [spice-server] build-sys: Improve ENABLE_EXTRA_CHECK setting

Frediano Ziglio fziglio at redhat.com
Tue Sep 12 10:59:45 UTC 2017


> 
> > 
> > On Tue, Sep 12, 2017 at 06:42:16AM -0400, Frediano Ziglio wrote:
> > > In this case you are introducing a regression, current code is
> > > designed to support this already. I cannot surely say that this
> > > patch is an improvement.
> > 
> > By that reasoning, any patch which makes some functions static or remove
> > some unused functions is a regression.
> > 
> > Christophe
> > 
> 
> Depends on the design. In this case is designed to be reused.
> 

Yes, you can correctly argue that this should be better documented.

Frediano


More information about the Spice-devel mailing list