[Spice-devel] [PATCH spice-server 09/10] red-channel-client: Simplify red_channel_client_wait_pipe_item_sent

[Christophe Fergeau]

On Tue, Sep 12, 2017 at 08:30:40AM -0400, Frediano Ziglio wrote:
> > 
> > On Mon, Sep 11, 2017 at 11:15:46AM +0100, Frediano Ziglio wrote:
> > > Instead of inserting the marker after the item (the tail of the queue
> > > is the first item to send) and then have to wait again if for
> > > the specific item place the marker before the item so waiting for
> > > the marker to be sent assure that we sent also the item.
> > > This avoids having to call red_channel_client_wait_outgoing_item
> > > and possibly the case where the item was not queued and
> > > red_channel_client_wait_outgoing_item returning TRUE even if
> > > the item was not sent as required.
> > 
> > As usual, I'd rework a bit the commit log (more punctuation/new lines, more
> > accurate references to typenames/variable names, ..):
> > 
> > "Currently, red_channel_client_wait_pipe_item_sent() inserts a MarkerItem
> > which
> > will sent before the item we want to wait for: the tail of the queue is
> > the first item to send, and the function uses
> > red_channel_client_pipe_add_before_pos(). Then, if the marker has been
> 
> I think here should be red_channel_client_pipe_add_after_pos.

Yes, thanks. API is too low-level and thus confusing ;)

Christophe